Skip to content

Log usage of build_uploader_from_params

Heinrich Lee Yu requested to merge log-deprecated-uploads-method into master

What does this MR do and why?

Adds logging to determine if we can remove this method.

Related to !122547 (comment 1420856610)

How to set up and validate locally

  1. Visit a non-existent upload (http://localhost:3000/flightjs/Flight/uploads/408ef1bf97db67e71bf8f56490cb6932/invalid.png)
  2. Check application_json.log. You should see something like:
{"severity":"INFO","time":"2023-06-07T11:54:06.447Z","correlation_id":"01H2AV9Z3TSFQPBM8QS5584HB6","meta.caller_id":"Projects::UploadsController#show","meta.remote_ip":"127.0.0.1","meta.feature_category":"not_owned","meta.user":"root","meta.user_id":1,"meta.client_id":"user/1","message":"Deprecated usage of build_uploader_from_params","class":"FileUploader","path":"invalid.doc","exists":false}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Heinrich Lee Yu

Merge request reports