Skip to content

Handle non-ASCII characters for topic_explore_projects_path

Thong Kuah requested to merge fix_topic_path into master

What does this MR do and why?

See https://gitlab.com/gitlab-org/gitlab/-/issues/393166 first

  1. Fix explore topic path to render non ASCII characters
  2. Do not allow certain characters for Projects::Topic#topic_name
  3. Follow-up !122970 (comment 1422903154)

Related issue: https://gitlab.com/gitlab-org/gitlab/-/issues/393166

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-06-08_at_8.29.01_PM Screenshot_2023-06-08_at_8.31.53_PM

How to set up and validate locally

See https://gitlab.com/gitlab-org/gitlab/-/issues/393166

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thong Kuah

Merge request reports

Loading