Skip to content

Fix GraphQL docs removing enum value

Luke Duncalfe requested to merge ld-fix-graphql-docs into master

What does this MR do and why?

After !117809 (merged), regenerating the GraphQL API reference doc file would remove the line with GITLAB_SLACK_APPLICATION_SERVICE, unless the developer had enabled the slack_app_enabled setting locally (see for example this message in #f_graphql - internal link, good for 90 days).

This was because the MR changed the logic of when the GitLab for Slack app was considered available to the GitLab instance from "Gitlab.com, development or test" !117809 (diffs) to "when the slack_app_enabled setting is enabled, or test". This change re-instates the logic that it is always available in development.

The MR had intentionally removed the logic of "always available in development" but unfortunately we can't do that yet without some more changes. In a future MR (hopefully !121620 (closed)) we'll refactor away the logic of checking Rails environments to decide if the GitLab for Slack app should be available.

QA steps

Run bundle exec rake gitlab:graphql:compile_docs locally on this branch and the GraphQL docs should not be updated.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Luke Duncalfe

Merge request reports