Skip to content

Refactor notification_service_spec.rb

euko requested to merge 18442-refactor-notification-specs into master

What does this MR do and why?

Some specs in notification_service_spec.rb are relying on the all mention (@all - be careful!) as a convenient helper to ping all relevant users rather than individually mentioning them to test the right users are notified.

This MR refactors the specs to remove the reliance so that we can deprecate the all mention easily and gracefully because the all mention itself will be the test subject.

Related to #18442 (closed)

Edited by euko

Merge request reports