Skip to content

Delegate handling after update of replicable models to replicator

Aakriti Gupta requested to merge ag-dry-up-handle-after-destroy into master

What does this MR do and why?

The change is a follow-up from an earlier review: #412225 (closed)

This MR DRYs up some code, so that Geo related handling after an update or destroy of a replicable model, is done by a call on the replicable model record itself. It is in turn delegated to the corresponding replicator.

This helps reduce duplication of checks like checking if node is primary and if replication through the self-service framework is enabled. Also, helps to have as little Geo replication code in other models, e.g. project, as possible.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading