Skip to content

Update delete confirmation modal for runner groups

Miguel Rincon requested to merge 409398-update-delete-confirmation-modal-for-runner-groups into master

What does this MR do and why?

Update delete confirmation modal for runner groups

This change allows users to see if they are deleting 1 or a group of runners by updating the confirmation modal UI text to indicate how many runners are being deleted.

Changelog: changed

Screenshots or screen recordings

Before After (one or no runners) 2 or more runners
image image image

How to set up and validate locally

You may see 0 or 1 on most test runners you use, to test this we can simulate having two separate machines with runner installed.

Install runner locally

  1. brew install runner works on MacOS (you may have to install an older version of runners)

Follow the instructions to create a runner

  1. Admin -> Runners
  2. Select "Create instance runner"
  3. Ensure you run the gitlab-runner register ... step

Simulate two machines

  1. Duplicate the configuration files cp -R ~/.gitlab-runner ~/.gitlab-runner-2
  2. Edit the random system id open ~/.gitlab-runner-2/.runner_system_id (changing one character will do)
  3. Run runner 1 gitlab-runner run
    • the default configuration at ~/.gitlab-runner will be used
  4. In another console tab, run runner 2 gitlab-runner run --config ~/.gitlab-runner-2/config.toml

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #409398 (closed)

Merge request reports