Skip to content

Connect GDK and other containers to the host network in e2e tests

Mark Lapierre requested to merge ml-e2e-gdk-use-network into master

What does this MR do and why?

Connect GDK and other containers to the host network in e2e tests, as per the documentation on using services and docker run with docker-in-docker.

  • Removes duplication in container networking
  • Adds Blocking and NonBlocking scenarios to group rspec tags (similar to Review(Non)Blocking, but signup is enabled on GDK).

Implements #410246 (closed)

Tasks

Test results

Known failures in master:

Reliable tests passed against GDK:

One test failed in https://gitlab.com/gitlab-org/gitlab/-/jobs/4502793945 (qa/specs/features/api/1_manage/rate_limits_spec.rb). This MR was intended to focus on runners so I'll investigate and fix that remaining test in a subsequent MR. Same for any failures in the non-blocking tests.

Failures in load balancer tests are a pre-existing issue: #415648 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mark Lapierre

Merge request reports

Loading