Skip to content

Update alert for not enough approvers

Alexander Turinske requested to merge 395545-add-approver-alert into master

What does this MR do and why?

Update alert for not enough approvers

  • add specific alert for when a user creates a policy that requires more approvers than selected
  • reset alert after action change
  • update tests

Changelog: changed

EE: true

What does this MR not do and why?

it doesn't outline the approver type or approvers because

  • the MR is already a bit complicated and I think validating the approver type and approvers will be too much in this MR
  • the designs have changed a bit since what was created on the issue so I wanted to sort that out in parallel with this MR

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
alert_-_b alert_-_a approver_alert_-_a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Navigate project/group => Secure => Policies => New policy => Scan result policy
  3. Add a large number of required approvers and save the policy
  4. Verify alert shows up and highlights number
  5. Change something
  6. Verify the alert disappears
  7. Verify the policy is saved

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #395545 (closed)

Edited by Alexander Turinske

Merge request reports

Loading