Broken master - Remove redundant `when Note` switch condition
Context
See gitlab-org/quality/engineering-productivity/master-broken-incidents#2767 (comment 1434036822):
Two MRs were merged at 1h interval, and they were both modifying the same concern,
app/models/concerns/spammable.rb:
This made rubocop unhappy on master, e.g. https://gitlab.com/gitlab-org/gitlab/-/jobs/4487418616.
What does this MR do and why?
There are currently two when Note switch statement: https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/concerns/spammable.rb#L108-113.
This MR removes one of them.
Does this fix work?
I works locally. We'll have to wait for the rubocop job to be sure.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by David Dieulivol