Remove git from preflight jobs
Context
Incident: #415739 (closed)
We have introduced !124073 (merged) to ensure that we would get errors if non-production gems misbehave.
This MR would not help against #415739 (closed), as the container image we use has git
already installed in it.
What does this MR do and why?
Remove git
binaries from the preflight jobs, so that we can catch errors when code depends on git, and when git isn't available.
Proof of work
I introduced a test commit to make the preflight jobs checks (it's a revert of the fix we made in !124141 (merged)).
Both jobs failed as expected
- https://gitlab.com/gitlab-org/gitlab/-/jobs/4503801300
- https://gitlab.com/gitlab-org/gitlab/-/jobs/4503801297
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by David Dieulivol