Skip to content

Prevent redefinition of shared examples

Aakriti Gupta requested to merge ag-spec-refactor into master

What does this MR do and why?

This MR refactors shared examples, so they are no longer nested and gets rid of the following warnings:

WARNING: Shared example group 'a counter of succeeded available verifiables' has been previously defined at:
  /Users/aakritigupta/Development/gdk-primary/gitlab/ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb:55
...and you are now defining it at:
  /Users/aakritigupta/Development/gdk-primary/gitlab/ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb:55
The new definition will overwrite the original one.
WARNING: Shared example group 'a counter of failed available verifiables' has been previously defined at:
  /Users/aakritigupta/Development/gdk-primary/gitlab/ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb:160
...and you are now defining it at:
  /Users/aakritigupta/Development/gdk-primary/gitlab/ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb:160
The new definition will overwrite the original one.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports