Skip to content

Draft: Enable JS to test new Vue password input - 1

Eduardo Sanz García requested to merge eduardosanz/vue-password-tests-1 into master

What does this MR do and why?

In the HAML, we replace the password field for a text field placeholder. This forces specs to use JavaScript execution to test the Vue password component as real users do.

On the second commit there are 7 specs that are still broken:

  • spec/features/usage_stats_consent_spec.rb
    • Line 25
  • spec/features/profiles/active_sessions_spec.rb
    • Line 16
  • spec/features/projects/show/redirects_spec.rb
    • Line 34
    • Line 47
  • spec/features/users/active_sessions_spec.rb
    • Line 6
  • spec/features/users/anonymous_sessions_spec.rb
    • Line 8
    • Line 20
    • Line 32
  • spec/features/users/email_verification_on_login_spec.rb
    • [1:1:2:1] Line 204
    • [1:3:1:1] Line 225
  • spec/features/users/login_spec.rb
    • Line 178
    • Line 188
    • Line 203
    • Line 441
    • Line 900

Screenshots or screen recordings

No applicable

How to set up and validate locally

No applicable

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eduardo Sanz García

Merge request reports

Loading