Combine 3 sign-in settings
What does this MR do and why?
We are combining these three settings, in this order:
-
Appearance.description
: Admin > Settings > Appearance > Sign in/Sign up pages > Description -
ApplicationSetting.sign_in_text
: Admin > Settings > General > Sign-in restriction > Sign-in text -
ApplicationSetting.help_text
: Admin > Settings > Preferences > Sign-in and Help page > Additional text to show on the sign-in page
The surviving field will be Appearance.description
The API options were marked as deprecated in 16.2, !125271 (merged).
In this MR we remove the Appearance.description
, ApplicationSetting.sign_in_text
in the following fashion:
- Commit #1: database migration
- Commit #2: frontend field removal
- Commit #3: backend field removal (that are used in the API too)
- Commit #4: changes in the documentation
Changelog: changed EE: true
Closes Redesigned Login Page: Options to modify sign i... (#385648 - closed)
Closes Combine sign-in appearances settings (#410885 - closed)
Screenshots or screen recordings
There should be no changes in the other or content of the custom fields.
Changes in the documentation:
Before | After |
---|---|
How to set up and validate locally
- Before checking this branch
- Setup the three setting options above.
- On an incognito window, take a look at the sign-in page: https://gdk.test:3443/users/sign_in
- Checking the branch and apply migration script here.
- The sign-in page should look identical.
- The two last settings options should not be visible.
Changes in the documentation:
- Check https://gdk.test:3443/help/user/admin_area/settings/sign_in_restrictions.md
- Check https://gdk.test:3443/help/user/admin_area/settings/help_page.md
- Check https://gdk.test:3443/help/api/settings.html
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Eduardo Sanz García