Skip to content

Explain when not to use a transactional migration

euko requested to merge update-section-on-migration-and-transaction into master

What does this MR do and why?

This MR updates the parts of the migration style guide that touch on transactions.

Specifically, it

  1. moves up the section #heavy-operations-in-a-single-transaction under #atomicity for a better exposition.

  2. adds a new section that summarizes when disable_ddl_transaction! should be used with additional explanation

  3. adds a new section with an example SQL snippet that uses SET LOCAL lock_timeout to to illustrate the problems the lock retry helper is trying to prevent.

  4. and finally adds a section on disable_statement_timeout.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by euko

Merge request reports