Skip to content

Refactor runner buttons into "action and button"

Miguel Rincon requested to merge 360429-runner-details-buttons-refactor into master

What does this MR do and why?

Refactor runner actions

This internal change splits the buttons component logic for pausing and deleting individual runners. So the resulting components can be reused in using a different appearance.

Splits mutation button components into delete action (with the mutation) and button (presentation).

For example, the delete action can now be used in presentations that are not buttons.

Why this change?

In #360429 (closed) our buttons will take the form of dropdown items depending on the layout, this decoupling allows us to add this new appearance.

Screenshots or screen recordings

List Details
image image

How to set up and validate locally

  1. Visit Admin -> Runners to see a list of runners
  2. Create 2 new runners
    • You don't have to register them, just go back to the list after seeing Runner created
  3. Visit Admin -> Runners and select the newly created runners
  4. Select Edit, Pause, and Delete to check the buttons in the list work
  5. Select the remaining runner
  6. Select Edit, Pause, and Delete to check the buttons in the details work

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #360429 (closed)

Edited by Miguel Rincon

Merge request reports