Skip to content

Run rubocop when monorepo gems also changed

Lin Jen-Shin requested to merge rubocop-dependant-rules into master

What does this MR do and why?

Run rubocop when monorepo gems also changed

Because we do run RuboCop against them. We do exclude vendor/gems on the other hand.

This is tested at !124770 (closed) where it does run rubocop and caught it: https://gitlab.com/gitlab-org/gitlab/-/jobs/4552213080

This is a corrective action for gitlab-org/quality/engineering-productivity/master-broken-incidents#2831 (comment 1448033532)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lin Jen-Shin

Merge request reports

Loading