Skip to content

Move GitLab Pages URL logic to a single place

Kassio Borges requested to merge kassio/extract-pages-url-methods-from-project into master

What does this MR do and why?

To avoid spreading GitLab Pages URL logic around the monolith, move the existing logic from models/project.rb and models/ci/artifact_blob.rb to lib/gitlab/pages/url_builder.rb.

Related to: https://docs.gitlab.com/ee/development/software_design.html#taming-omniscient-classes

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Kassio Borges

Merge request reports