Skip to content

Fix cancelling of note edits

Heinrich Lee Yu requested to merge 416728-fix-polling-notes-cancel into master

What does this MR do and why?

Restores the note contents correctly when a poll which updates the note contents happen while the user is editing

How to set up and validate locally

  1. Edit a note by clicking the pencil icon
  2. Change the text to something else but do not click save
  3. On another tab, update the note to something else.
  4. On the original tab, an alert should be shown saying the note has been edited by someone else.
  5. Cancel editing

Correct behavior is that it gets restored to the updated contents from polling and not the original text at the time the edit button was clicked.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #416728 (closed)

Edited by Heinrich Lee Yu

Merge request reports

Loading