Skip to content

Rename `Groups::EnterpriseUsers::CreateService` class and its email

Bogdan Denkovych requested to merge bdenkovych-rename-enterprise-users-service-class-and-mailer into master

What does this MR do and why?

Since the service class associates the user to the enterprise group, I want to rename the service class from Groups::EnterpriseUsers::CreateService to Groups::EnterpriseUsers::AssociateService to emphasize it better. The current version of the service class name could be confusing - it might lead to false expectations that it creates a User. This service class hasn't been used in the GitLab system yet. We prepare it for future use &9675 (closed).

In !123666 (merged), we added Notify.enterprise_user_account_created_email(user_id) email for that service class. While it is not too late, I want to rename this email to Notify.user_associated_with_enterprise_group_email to emphasize better what this email is about. I said 'While it is not too late' because any mailer is a worker, and after it's been used, it is unsafe to change its method signature the way this MR does. Since the service hasn't been used in the GitLab system yet, this email also hasn't been used. So we still have an opportunity to give this email a better name by direct renaming it, It should be safe.

How to set up and validate locally

https://gdk.test:3443/rails/mailers/notify/user_associated_with_enterprise_group_email

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Bogdan Denkovych

Merge request reports