Skip to content

Add external_dependencies label to Sidekiq SLI

Gregorius Marco requested to merge mg-external-dependencies-label-sidekiq-sli into master

What does this MR do and why?

Since we are excluding external_dependencies: yes in the Sidekiq per-shard SLIs https://gitlab.com/gitlab-com/runbooks/-/blob/bab1347559f107dfdaf171bd95f4e4c2eeb7c3a2/metrics-catalog/services/sidekiq.jsonnet#L91, this MR includes the external_dependencies label in Sidekiq application SLIs (execution & queueing). This label will then be used in metrics catalog SLIs gitlab-com/runbooks!5654 (comment 1455299133) to exclude similar to the per-shard SLIs above.

How to set up and validate locally

  1. Enable FF Feature.enable(:sidekiq_execution_application_slis)
  2. You should see external_dependencies label in:
$ curl 'gdk.test:3807/metrics' | rg gitlab_sli_sidekiq_execution
gitlab_sli_sidekiq_execution_total{external_dependencies="no",feature_category="cell",urgency="low",worker="Database::CiProjectMirrorsConsistencyCheckWorker"} 1
...

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Gregorius Marco

Merge request reports