Skip to content

Remove old @rails/ujs patch

Mark Florian requested to merge fix-patch-package-warning into master

What does this MR do and why?

Remove old @rails/ujs patch

This avoids a spurious warning from patch-package about an out of date patch successfully applying to @rails/ujs.

It seems that !124694 (merged) correctly added a new patch for the new version 7.0.5-1, but did not delete the patch for the old version, 7.0.5.

Screenshots or screen recordings

Before

yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
success Already up-to-date.
$ node ./scripts/frontend/postinstall.js
success Dependency postinstall check passed.

Warning: patch-package detected a patch file version mismatch

  Don't worry! This is probably fine. The patch was still applied
  successfully. Here's the deets:

  Patch file created for

    @rails/ujs@7.0.5

  applied to

    @rails/ujs@7.0.5-1
  
  At path
  
    node_modules/@rails/ujs

  This warning is just to give you a heads-up. There is a small chance of
  breakage even though the patch was applied successfully. Make sure the package
  still behaves like you expect (you wrote tests, right?) and then run

    patch-package @rails/ujs

  to update the version in the patch file name and make this warning go away.

---
patch-package finished with 1 warning(s).
success Packages successfully patched.
Done in 0.44s.

After

yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
success Already up-to-date.
$ node ./scripts/frontend/postinstall.js
success Dependency postinstall check passed.
success Packages successfully patched.
Done in 0.60s.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mark Florian

Merge request reports

Loading