Fix target note background for first timeline note
What does this MR do and why?
Closes Linking to the first note in a thread does not ... (#417137 - closed)
| Video explaining the issue |
|---|
| Screen_Recording_2023-07-06_at_4.49.55_PM |
This MR fixes the issue wherein the main target note is not highlighted when landing from other page. The threads are highlighted as expected.
Looks like a possible regression of a series of MR's but interesting it has not been caught yet.
I haven't been able to find out the root cause of this issue.
This was definitely working until !123626 (diffs)+ got merged. And there have been a series of changes in notes.scss background color which have led to other changes.
For example : !123626 (diffs)+ got reverted in Update "reply" input container (!124491 - merged) eventually , see history of these lines https://gitlab.com/gitlab-org/gitlab/-/blob/9ef05c73d5a490a4c00dbe59cbc808ab6fe641d4/app/assets/stylesheets/framework/timeline.scss#L46-48
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
 |
 |
How to set up and validate locally
- Go to any issuable/work item , write a comment and click on three dots. Click copy link
- Open the link in a new tab
- See that it is highlighted in blue
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
Open the comment of issue from a todo/ mail and see that the background is highlighted -
Open the comment of MR from from todo/mail and see that the background is highlighted -
Open the comment of Work Item from any comment by copying the link -
Check the same for objective/key results
Related to #417137 (closed)