Fix Missing 'Invite more members' CTA on 'Learn GitLab' page
requested to merge 417185-missing-invite-more-members-cta-on-alert-when-on-learn-gitlab-page into master
What does this MR do and why?
Fixes the bug described in #417185 (closed) where the Invite more members
button is missing on the learn gitlab page
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
Since it is hard to create a trial in development, due to CustomersDot dependencies, we can rely on the test added in ee/spec/features/learn_gitlab_spec.rb
or...
- Setup to simulate SaaS and restart GDK
- Register as a new user.
- Confirm email by finding the confirmation path from last User created in
rails console
Rails.application.routes.url_helpers.user_confirmation_path(confirmation_token: User.last.confirmation_token)
- Visit the path from the previous step.
- You should be on the sign in page, log back in.
- Select any 'role' and 'Just me' in the welcome form after sign up step.
- Choose 'Create a new project'
- Click 'Continue'
- Fill out fields to create a group and project on the next page.
- Click 'Create project'
- Verify you get to the onboarding and page refreshes to provide a "Ok, let's go" button.
- Click on "Ok, let's go" and verify you are dropped into the learn gitlab project and the celebrate modal pops up with confetti
- Go to
ee/app/views/shared/_unlimited_members_during_trial_alert.html.haml
and remove this line- return unless show_unlimited_members_during_trial_alert?(root_namespace)
- Close the modal that was open and reload the page to see the alert.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #417185 (closed)
Edited by Doug Stull