Skip to content

Fixes container registry tags list sorting UI inconsistency

Rahul Chanila requested to merge 409771-container-registry-tags-list-ui-sorting-behaves-inconsistently into master

What does this MR do and why?

  • Updates the apollo cache policy for tags list query
  • Removed explicit calls to fetchMore by updating pageParams instead
  • Refactor loading so that there is less shift in layout

Screenshots or screen recordings

Before After
Screen_Recording_2023-05-03_at_14.12.52 Screen_Recording_2023-07-11_at_4.41.31_pm

How to set up and validate locally

  1. Setup & enable Container Registry https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/registry.md
  2. Add a few images with tags by following https://gitlab.com/gitlab-org/ci-cd/package-stage/package/-/wikis/Packages-Tips-&-Tricks#how-to-add-images-with-tags-quickly-to-the-registry
  3. Alternatively, in the terminal 
    $ docker pull hello-world
$ for i in `seq -f "%02g" 1 25`; do docker tag hello-world 127.0.0.1:5000/<project-path>/hello-world:$i; done
$ for i in `seq -f "%02g" 1 25`; do docker push 127.0.0.1:5000/<project-path>/hello-world:$i; done
  4. Visit the container registry list page for the project
  5. Clicking one of the images should take you the tags list(details) page
  6. Switching the sort order on the UI should always reset pagination (i.e. send us back to the 1st page)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #409771 (closed)

Edited by Rahul Chanila

Merge request reports