Skip to content

Mass button migration, part 4

Mark Florian requested to merge mf-button-migration-4 into master

What does this MR do and why?

This migrates many links that are styled to look like buttons to the link_button_to helper added in !121772 (merged).

These migrations were largely done blind, in that a codemod was used to perform them.

Commits

Migrate some Verify buttons

This was extracted from !125126 (merged) to isolate the changes which required approval from Verify.

Executed with:

comby \
    -config ~/dev/pajamas-adoption-scanner/comby/button-2.toml \
    -custom-matcher ~/dev/pajamas-adoption-scanner/comby/haml.json \
    -matcher .generic -in-place \
    -f .haml

Using the button-migration branch of the Pajamas Adoption Scanner: https://gitlab.com/gitlab-org/frontend/pajamas-adoption-scanner/-/commits/button-migration

Screenshots or screen recordings

There should be no visual changes.

How to set up and validate locally

The rendered markup should be equivalent, so there's not much need to validate this locally. The approach has already been validated in !121772 (merged) and !125126 (merged) (see the UX review checklists).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mark Florian

Merge request reports