Draft: Remove unused .branch-info .commit-icon styles
What does this MR do and why?
Migrate some styles out of commits.scss
to page specific bundles.
-
.commit-description
app/views/projects/commit/_commit_box.html.haml
app/views/shared/wikis/diff.html.haml
-
.commit-row-description
app/views/projects/commits/_commit.html.haml
-
ee/app/assets/javascripts/vue_merge_request_widget/components/ai_commit_message.vue
->app/views/projects/merge_requests/_widget.html.haml
-
app/assets/javascripts/diffs/components/commit_item.vue
->app/views/projects/merge_requests/_page.html.haml
-
app/assets/javascripts/repository/components/last_commit.vue
->app/views/projects/_files.html.haml
-
.commit-box
app/views/projects/commit/_commit_box.html.haml
-
.pipeline-info .status-icon-container
- Removed as it did not seem to be used anywhere.
-
.branch-info .commit-icon
- Unused since 3f56fd65, removed.
-
.commit-message-container
-
app/views/shared/_commit_message_container.html.haml
: The style does not seem to be applied properly here so I did not backport it. -
app/assets/javascripts/merge_conflicts/merge_conflict_resolver_app.vue
->app/views/projects/merge_requests/conflicts/show.html.haml
-
-
.commit-row-title .str-truncated
app/views/projects/commits/_inline_commit.html.haml
-
.commits-row
app/views/projects/commits/_commits.html.haml
-
.text-expander
: Probably needs to be global as it's used in the breadcrumbs. Moved toframework.scss
.-
app/assets/javascripts/repository/components/last_commit.vue
->app/views/projects/_files.html.haml
-
app/assets/javascripts/vue_shared/components/expand_button.vue
app/views/projects/releases/show.html.haml
app/views/projects/releases/index.html.haml
app/views/projects/commits/_commit.html.haml
app/views/layouts/nav/breadcrumbs/_collapsed_inline_list.html.haml
-
-
.commit.flex-list
: Apparently not used anywhere, removed. -
.avatar-cell img
: Removed altogether as it didn't seem to be actually applied anywhere.-
app/assets/javascripts/diffs/components/commit_item.vue
-
app/views/projects/commits/_commits.html.haml
: Not actually initialized here. -
app/views/projects/merge_requests/_commits.html.haml
: Seems unnecessary here
-
-
app/views/projects/commits/_commit.html.haml
: Overridden, no need to backport. -
app/views/search/results/_user.html.haml
: Overridden, no need to backport.
-
.add-review-item
-
.add-review-item-modal
-
app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_wrapper.vue
app/views/projects/commits/_commits.html.haml
app/views/projects/merge_requests/_commits.html.haml
-
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #239804
Edited by Paul Gascou-Vaillancourt