Skip to content

Migrate link_to buttons to Pajamas buttons in commits_helper.rb

Annabel Dunstone Gray requested to merge pajamas-migrations into master

What does this MR do and why?

Migrate link_to buttons to Pajamas buttons in commits_helper.rb

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Commit page Screenshot_2023-07-14_at_12.15.25_PM Screenshot_2023-07-14_at_12.14.55_PM
Commits list view Screenshot_2023-07-14_at_2.44.13_PM Screenshot_2023-07-14_at_2.41.17_PM

How to set up and validate locally

Go to a commit (eg http://localhost:3000/gitlab-org/gitlab-test/-/commit/ddd0f15ae83993f5cb66a927a28673882e99100b)

  • Check Browse files button in top right page
  • Check View <sha> button in top right of file

Go to commits page (eg http://localhost:3000/gitlab-org/gitlab-test/-/commits/master_

  • Check Browse files folder icon button on far right of each commit

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Migrate to Pajamas compliant buttons in app/hel... (#417797 - closed)

Edited by Annabel Dunstone Gray

Merge request reports

Loading