Skip to content

Start migrating clipboard_button helper to ::Pajamas::ButtonComponent

Paul Gascou-Vaillancourt requested to merge pj-clipboad-button into master

What does this MR do and why?

Start migrating clipboard_button helper to ::Pajamas::ButtonComponent.

Since the clipboard_button helper is being used in many places at the moment, it might be safer to migrate usages iteratively. This MR proposes a first iteration that...

  • ...renames clipboard_button to deprecated_clipboard_button.
  • ...introduces a new clipboard_button helper that renders a ::Pajamas::ButtonComponent under the hood.
  • ...migrates a couple usages to the newer helper.

Re #417829 (closed), #417844 (closed)

Screenshots or screen recordings

Before After
app/views/projects/commits/_commit.html.haml Screenshot_2023-07-14_at_3.51.03_PM Screenshot_2023-07-14_at_3.43.26_PM
app/views/shared/_mobile_clone_panel.html.haml Screenshot_2023-07-14_at_3.51.17_PM Screenshot_2023-07-14_at_3.43.00_PM

How to set up and validate locally

  1. Navigate to a project's commits page (e.g. http://gdk.test:3000/gnuwget/Wget2/-/commits/master?ref_type=heads)
  2. Navigate to a project's overview page with the window resized to the narrowest viewport (e.g. http://gdk.test:3000/gnuwget/Wget2).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Paul Gascou-Vaillancourt

Merge request reports

Loading