Skip to content

Migrate some clipboard buttons to Pajamas-compliant helper

Paul Gascou-Vaillancourt requested to merge migrate-some-clipboard-btns into master

What does this MR do and why?

Migrates a few instances of deprecated_clipboard_button to the new clipboard_button helper that renders a ::Pajamas::ButtonComponent.

Screenshots or screen recordings

Before After
app/views/projects/commit/_commit_box.html.haml Screenshot_2023-07-14_at_5.13.14_PM Screenshot_2023-07-14_at_5.10.57_PM
app/views/shared/milestones/_description.html.haml Screenshot_2023-07-14_at_5.13.22_PM Screenshot_2023-07-14_at_5.11.07_PM
app/views/groups/_home_panel.html.haml Screenshot_2023-07-14_at_5.13.30_PM Screenshot_2023-07-14_at_5.11.15_PM
app/views/projects/branches/_branch.html.haml Screenshot_2023-07-14_at_5.13.40_PM Screenshot_2023-07-14_at_5.11.30_PM

How to set up and validate locally

  1. Navigate to a commit details page (e.g. http://gdk.test:3000/twitter/Typeahead.Js/-/commit/5f975fc2e61fb5e6b064ee040d42df2cf962657a).
  2. Navigate to a milestone's details page (e.g. http://gdk.test:3000/twitter/Typeahead.Js/-/milestones/6#tab-issues).
  3. Navigate to a group's info page (e.g. http://gdk.test:3000/twitter/Typeahead.Js).
  4. Navigate to a repository's branch list (e.g. http://gdk.test:3000/twitter/Typeahead.Js/-/branches).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Paul Gascou-Vaillancourt

Merge request reports

Loading