Migrate jQuery-based Protected Tag Dropdown to Vue
requested to merge gitlab-community/gitlab:284787-migrate-protected-tag-access-dropdown-to-vue into master
What does this MR do and why?
Migrate deprecated usage of jQuery-based AccessDropdown on Protected Tags:
- app/assets/javascripts/protected_tags/protected_tag_create.js
- app/assets/javascripts/protected_tags/protected_tag_edit.js
Screenshots or screen recordings
Without EE License
| Before | After |
|---|---|
 |
 |
 |
 |
With EE License (/w Search)
| Before | After |
|---|---|
 |
 |
 |
 |
How to set up and validate locally
Protected Tags
- Open a project and go to Settings > Repository > Protected Tags
-
protected_tag_createis the default dropdown used for protecting tags. -
protected_tag_editis the dropdown used in the list of already protected tags (edit).
The EE variant should have a search input inside the dropdown content.
Protected Environment
Since we indirectly modify components that is shared by add_approvers.vue, we must also test for its behavior.
- Go to Settings > CI/CD > Protected Environment
- Add a new protected environment.
- The "Approver" section should be the one tested for any behavior change/issues.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #284787 (closed)
Edited by Shane Maglangit (Personal)