Skip to content

E2E test: only close popup once when merging

Jay McCure requested to merge jmc-close-popup-once-fix into master

What does this MR do and why?

Since merge! immediately calls try_to_merge! we only need to close the rich text popup once in try_to_merge!

Resolves #418873 (closed) as it was trying to close the popup twice.

How to set up and validate locally

bundle exec rspec qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jay McCure

Merge request reports

Loading