Skip to content

[E2E] Add an assertion that rich text promo is gone after close

John McDonnell requested to merge jmd/assert-no-rich-text-popover-after-click into master

What does this MR do and why?

Follow up to !126924 (comment 1476351040)

The current method closes the Rich Text Popover with a click but doesn't verify that it's actually gone afterwards.
Depending on the flow of the tests, if someone were to call this method a second time in quick succession a flake could happen where

  1. close_rich_text_promo_popover_if_present called
  2. the click happens
  3. close_rich_text_promo_popover_if_present called
  4. the closes milliseconds after the first click
  5. an error because the element is gone so the second click cannot find the element

This change will prevent that by blocking until the element is gone after a click.

See #418873 (comment 1473698441)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by John McDonnell

Merge request reports