Skip to content

Removing full stop from Learn More link

Amber Parker requested to merge move-full-stop-414676 into master

What does this MR do and why?

Moves the full stop outside of the Learn More link.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-07-20_at_11.09.18_AM Screenshot_2023-07-21_at_3.00.18_PM

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Navigate to http://{local-instance}/flightjs/Flight/-/pipeline_schedules/new
  2. In the file gitlab/app/assets/javascripts/pages/projects/pipeline_schedules/shared/components/interval_pattern_input.vue, change line 99 to the following, so the correct message is displayed.
text: s__('PipelineScheduleIntervalPattern|Custom (%{linkStart}Learn more%{linkEnd}.)'),
  1. Or navigate to gitlab-development-kit and switch branch to move-full-stop-414676 and reload the page http://{local-instance}/flightjs/Flight/-/pipeline_schedules/new
  2. Check for the changes made

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to: #414676 (closed)

Edited by Amber Parker

Merge request reports