Skip to content

Document that :migration RSpec tag is automatically added

Dylan Griffith requested to merge clarify-spec-migration-tag-docs into master

What does this MR do and why?

This confused me because I always remembered we had to add this and then I later noticed that plenty of migration specs don't have it. I couldn't quite figure this out but Simon pointed me to https://gitlab.com/gitlab-org/gitlab/-/blob/9614da1aeb99eceb7fd2cd297c02dbd9a7fa108f/spec/spec_helper.rb#L139 which shows that we are adding the tag based on metadata[:level] which is mapped from file paths at https://gitlab.com/gitlab-org/gitlab/-/blob/cf1e3196bb9db1f9ef572b586c4ff90100f24702/tooling/quality/test_level.rb#L7-14 .

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports