Skip to content

Update Pipeline license report row testid selector strings in QA page

Will Meek requested to merge license-scan-spec-fix into master

What does this MR do and why?

Fix for #420838 (closed)

This is due to !127740 (merged) enforcing strict case matches on testid attributes

So looking for

            def has_license?(name)
              has_element?(:report_item_row, text: name)
            end

won't match report-item-row

Fix

Convert all usages of the symbol :report_item_row to the snake-case 'report-item-row' string

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

n/a

How to set up and validate locally

From QA directory, target staging:

<STAGING VARIABLES FROM ONE PASSWORD> QA_DEBUG=true bundle exec bin/qa Test::Instance::All https://staging.gitlab.com qa/specs/features/ee/browser_ui/13_secure/license_scanning_spec.rb:75

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports