Skip to content

Avoid caching patched node modules

Lin Jen-Shin requested to merge reverse-patch-before-upload-frontend-cache into master

What does this MR do and why?

This is based on !128768 (merged)

Avoid caching patched node modules

If we cache patched node modules, whenever we change the patch, it'll not apply to the patched modules. Patching is very fast so this should not be an issue.

Using after_script is fine because we run it before uploading cache: https://docs.gitlab.com/ee/ci/caching/#how-archiving-and-extracting-works

We also don't need to touch apt sources because it's left out from d2cc841c which was long ago. It's needed when we're running install_api_client_dependencies_with_apt and we're not doing that anymore.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading