Skip to content

Add all protected branches settings information

Alexander Turinske requested to merge 418766-add-tooltip into master

What does this MR do and why?

Add all protected branches settings information

  • add information icon with popover
  • add tests

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Scenario Screenshot
"All Protected Branches" selected w/ ff apb_w__ff
"All Protected Branches" selected w/out ff apb_w_out_ff
"All Protected Branches" not selected apb_not_selected
On new policy page load new_policy
On existing policy page load existing_policy

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Navigate to a project/group => Secure => Policies => New policy => Scan Result Policy
  3. Verify the information icon does not show for any type of branch type selected
  4. Turn on the ff
echo "Feature.enable(:scan_result_policy_settings)" | rails c
  1. Verify the information icon only shows for all protected branches type of branch type selected

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #418766 (closed)

Edited by Alexander Turinske

Merge request reports

Loading