Skip to content

Remove etag caching of notes endpoints

Heinrich Lee Yu requested to merge remove-notes-etag-caching into master

What does this MR do and why?

Etag caching is no longer needed since we are no longer continuously polling these endpoints now that we use Action Cable.

The request to this endpoint is only made when we connect to Action Cable and when an actual change to a note happens. Due to this, the hit rate of this cache is now quite low: https://thanos-query.ops.gitlab.net/graph?g0.expr=sum(rate(gitlab_transaction_event_etag_caching_cache_hit_total%7Benv%3D%22gprd%22%2C%20exported_endpoint%3D~%22issue_notes%7Cmerge_request_notes%7Cepic_notes%22%7D%5B5m%5D))%20%20%2F%20sum(rate(gitlab_transaction_event_etag_caching_middleware_used_total%7Benv%3D%22gprd%22%2C%20exported_endpoint%3D~%22issue_notes%7Cmerge_request_notes%7Cepic_notes%22%7D%5B5m%5D))&g0.tab=0&g0.stacked=0&g0.range_input=1d&g0.max_source_resolution=0s&g0.deduplicate=1&g0.partial_response=0&g0.store_matches=%5B%5D

Removing this saves us from the Redis SET calls we make every time a note is created / updated and the GET every time this endpoint is hit.

Related to #412823 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Heinrich Lee Yu

Merge request reports