Skip to content

Remove PAT field for Code Suggestions: UI part

Aleksei Lipniagov requested to merge 422037-remove-code-suggestions-pat-field into master

What does this MR do and why?

PAT field is no longer required in App Settings from 16.3: !127987 (merged)

From 16.4, we remove it from UI, and all the related backend code, and start the column deprecation process.
The reason for that is switching to a different authentication mechanism that was introduced in 16.3. That new flow will no longer use PAT field.

This MR is for UI (user-facing) changes only.

While removing the PAT field from UI will be fully completed in %16.4, we will need three releases (%16.4 , %16.5 , %16.6 ) to fully remove the column safely. It will be tracked in #422174 (closed) in done in a separate MR.

The backend code that uses ::Gitlab::CurrentSettings.ai_access_token will be removed separately under #422379 (closed).

Docs will be updated separately under #422052 (closed).

I am doing UI MR separately for various reasons:

  • it will require frontend review. It also touches locales. Other changes won't.
  • this is the only MR in a series that does user-facing changes (aside from documentation)
  • as a result, manual testing is different for this MR and could be concentrated exclusively on the AppSetting page
  • iteration: to ship smaller changes

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-08-17_at_15.18.18 Screenshot_2023-08-17_at_15.17.23

How to set up and validate locally

Prerequisite: Make sure you have a license on your GDK! (so it will act as EE Premium/Ultimate)
Otherwise, the "Code Suggestions" section will not be shown to you in Application Settings.

Master

  1. Check master
  2. Visit http://localhost:3000/admin/application_settings/general, scroll down, and find the Code Suggestions section
  3. You will notice the checkbox and also the PAT field

On this branch

  1. Check this branch: 419770-ai-make-pat-field-optional-for-sm
  2. Visit http://localhost:3000/admin/application_settings/general, scroll down, and find the Code Suggestions section
  3. Only checkbox is rendered, not PAT field anymore

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #422037 (closed)

Edited by Aleksei Lipniagov

Merge request reports