Access tokens - show token name in delete copy
requested to merge gitlab-community/gitlab:jah/420303/copy-changes-personal-access-tokens into master
What does this MR do and why?
Reference issue: #420303 (closed)
Reference help conversation: https://discord.com/channels/778180511088640070/997442331202564176/1141435196831449148
I'd like to get insights into what the name of the token that is being deleted, similar to SSH keys.
Changes copies for:
- personal access tokens
- project tokens
- group tokens
-Are you sure you want to revoke this personal access token? This action cannot be undone.
+Are you sure you want to revoke the personal access token "Foo Bar"? This action cannot be undone.
Screenshots or screen recordings
This MR aims to align the behaviour seen in the deletion of SSH keys and also adds it for access tokens.
SSH Key Deletion Modal (current production):
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
- Navigate to https://gitlab.com/-/profile/personal_access_tokens
- Add a Personal Access Token
- Delete it, and observe the delete modal for the copy.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Jos Ahrens