Skip to content

Add support for destroyed event to Vue version of contribution events

Peter Hegman requested to merge 378677-add-destroyed-event into master

What does this MR do and why?

Related to #378677 (closed)

In &9056 we are migrating the user profile from HAML/jQuery to Vue. This is a large migration so we are splitting it up into many sections. This MR continues to build out the Activity section on the Overview tab.

There are many contribution events that we will need to support. These are documented in https://docs.gitlab.com/ee/user/profile/contributions_calendar.html#user-contribution-events. This MR adds the destroyed contribution event. In future MRs I will be iteratively adding support for the other contribution event types.

Currently supported events:

  • approved
  • expired
  • joined
  • left
  • pushed
  • private
  • merged
  • created
  • closed
  • commented
  • reopened
  • updated
  • destroyed (this MR)

UX note: There is currently an incorrect bottom border in the tabs. This is due to a recent change in !118597 (merged). We will be removing the tabs and moving the navigation into the new sidebar in #389842. By removing the tabs we will be able to fix this bug and because this is behind a feature flag I am going to leave it as-is for now.

Screenshots or screen recordings

Before After
Screenshot_2023-08-16_at_4.30.45_PM Screenshot_2023-08-16_at_4.30.01_PM

How to set up and validate locally

  1. Disable the super sidebar if you have it enabled. The Vue profile does not yet support it. Will be supported in #389842
  2. Enable the profile_tabs_vue feature flag
    • bin/rails console
    • Feature.enable(:profile_tabs_vue)
  3. Go to a project -> Wiki.
  4. If you already have a wiki page edit it then click the Delete button. If not create a new one and then edit and delete it.
  5. Go to a project -> Issues -> Milestones.
  6. Click on a milestone and delete it
  7. Go to an issue and upload a design.
  8. Click on the design then click the Archive button

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports