Skip to content

Update danger bot warning when finalizing background migration

Krasimir Angelov requested to merge ka/update-danger-bot-waarning-from-128016 into master

What does this MR do and why?

With !128016 (merged) we added new Danger check that posts the following when we are finalizing a background migration:

Finalizing data migration might be time consuming and require a required stop. Check the timings of the underlying data migration. If possible postpone the finalization to the scheduled required stop. If postponing is impossible please create new required stop as documentation suggests.

This is incorrect, as scheduling the finalization for the required stop will not help, as it will happen during the upgrade to the release that should be required stop. Indeed our docs say that we should "Schedule finalization for the first minor version after the next required stop" - https://docs.gitlab.com/ee/development/database/required_stops.html#long-running-migrations-being-finalized.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports