Skip to content

Fix reference to groupApprovers in security approvals

Sashi Kumar Kumaresan requested to merge sk/fix-group-approvers into master

What does this MR do and why?

Addresses #422609 (closed)

Fix reference to groupApprovers in security approvals

This change fixes a bug caused by using groupApprovers instead of allGroupApprovers in approval rules settings page which was introduced in !128013 (merged).

Screenshots or screen recordings

Before After
Screenshot_2023-08-18_at_10.48.41_PM Screenshot_2023-08-18_at_10.48.27_PM

How to set up and validate locally

  • Create a scan result policy for a project
  • Go to Settings -> Merge requests and go to Security Approvals section and notice that the section shows the approvals from scan result policy

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sashi Kumar Kumaresan

Merge request reports

Loading