Skip to content

Use Pajamas ButtonComponent for button in BannerComponent

Thomas Hutterer requested to merge 416062_migrate_button_in_banner_component into master

What does this MR do and why?

Use Pajamas::ButtonComponent for button in Pajamas::BannerComponent.

This requires a small change to the BannerComponent initializer to always add the CSS classes that our JS needs.

Screenshots or screen recordings

No visual change.

How to set up and validate locally

  • You can use our local Lookbook to verify that nothing changed visually: http://gdk.test:3000/rails/lookbook/inspect/pajamas/banner/default
  • Switch to the HTML tab to see the comments that annotate the partial/component filenames that got rendered. You should see an extra <!-- BEGIN app/components/pajamas/button_component.rb --> comment now.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports