Tidy issue/incident code
What does this MR do and why?
This MR tidies issue/incident code and removes some duplicate code.
No changelog as there are no user changes
Screenshots or screen recordings
How to set up and validate locally
Checking issues
- Go to issue http://127.0.0.1:3000/flightjs/Flight/-/issues/1
- Confirm there are no error messages, confirm the top button says
Close issue
and the ellipsis dropdown menu containsNew related issue
andDelete issue
- Click
Close issue
> confirm there are no error messages
Checking incidents
- Go to http://127.0.0.1:3000/flightjs/Flight/-/incidents > Click
Create incident
- Add title > Click
Create issue
- Confirm there are no error messages, confirm the top button says
Close incident
and the ellipsis dropdown menu containsNew related incident
andDelete incident
- Click
Close incident
> confirm there are no error messages
Checking hasClosingMergeRequest
change
- Go to http://127.0.0.1:3000/flightjs/Flight/-/merge_requests > Click
New merge request
- Click
Select source branch
dropdown > select any branch > clickCompare branches and continue
- Add
Closes #1
to description > clickCreate merge request
- Go to issue
#1
http://127.0.0.1:3000/flightjs/Flight/-/issues/1 > Scroll down toRelated merge requests
widget and confirm it saysWhen this merge request is accepted, this issue will be closed automatically
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Coung Ngo