Skip to content

Use _path helper instead of _url helper

Thomas Hutterer requested to merge 416213-switch-to-new-nav-fix into master

What does this MR do and why?

Similar to !127890 (merged), this MR replaces url-helpers with path-helpers. This should help with Why my GitLab instance is resolving to 127.0.0.... (#416213 - closed) where a customer reported problems with these _url-links on their self-managed instance. Read through the issue to see how we came to this solution and #416213 (comment 1523154043) for this particualar change.

In general, it’s preferred to use a path (/photos/10) over a full URL (http://domain.com/photos/10). This is because the URL uses the hostname configured with GitLab which may not match the request. Source

Screenshots or screen recordings

No visual change.

How to set up and validate locally

Note that in a normal setup, incl your GDK, there is no functional change. Just verify that it still works :)

a9ff78be

  • First, enable the old navigation (in the user dropdown behind the avatar in the lefthand sidebar)
  • Toggle on the new navigation (in the top-right user dropdown)

b11e5be0

  • Open an MR and create a conflict in it. Quickest way to do this is probably through the single-file editor.
  • Then resolve the conflict in the web UI. You can find a screen recording of the the steps and it failing for the customer here: #416213 (comment 1494138497)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #416213 (closed)

Edited by Thomas Hutterer

Merge request reports