Skip to content

Fix flaky spec by expecting alert before waiting for requests

John Hope requested to merge fix-flaky-spec-408203 into master

What does this MR do and why?

Fixes and unquarantines the flaky spec detailed in #408203 (closed)

This has a similar root cause to !130216 (merged). The visit method was monkeypatched to wait_for_requests, but we need to insert the expectation of an alert/confirm between these two actions. The mentioned MR allows this method to take a block and this can be used to place the expectation.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports