Skip to content

Remove generic rescue on project config

Brian Williams requested to merge bwill/remove-rescue-on-project-config into master

What does this MR do and why?

Stop rescuing StandardError when creating the ProjectConfig, as this leads to unreliable behavior. Currently, a build might randomly have nil JWTs, when this is something that should be present for 100% of builds that need them. ProjectConfig might raise if there are problems with connecting to Gitaly. I believe that it is acceptable to allow the error to raise in this case instead of swallowing it.

In the last 7 days, there's been 39 errors originating from this code (source: Kibana). All of them are related to Gitaly connectivity.

Screenshot_2023-08-31_at_10.50.39_AM

Approximately 7 million builds are created on GitLab.com per day (source: Sisense), which means that the error rate here is approximately 0.000079%.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Brian Williams

Merge request reports