Skip to content

Fix flaky spec 397683

John Hope requested to merge fix-flaky-spec-397683 into master

What does this MR do and why?

Fixes flaky spec #397683 (closed)

See inline comments for more specific information.

I think this spec is flaky because it reuses a factory. When the tests are run in parallel another test can update that factory while this one is running, causing a race condition. Even if this test would pass it would be testing the wrong thing.

This change consolidates some existing test blocks using different fixtures to simply use one new factory that is specific to this block of tests.

It also passes the dismissal/acceptance of the confirm dialog to the visit method, which has been a more recent source of flakiness.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by John Hope

Merge request reports

Loading