Skip to content

Enable DDL when recreating databases in tests

Krasimir Angelov requested to merge ka/broken-master/3476 into master

What does this MR do and why?

This resolves master:broken incident - gitlab-org/quality/engineering-productivity/master-broken-incidents#3476 (closed). When recreating database, and syncing partitions we need DDL enabled to create the required partitions.

Newly introduced disallow_database_ddl_feature_flags feature flag (!130554 (merged)) is disabling some DDL changes when enabled. Since feature flags are enabled by default in tests, this results in skipping syncing partitions, after we recreate databases in tests.

See gitlab-org/quality/engineering-productivity/master-broken-incidents#3476 (comment 1545305728) for more details.

How to set up and validate locally

gitlab-org/quality/engineering-productivity/master-broken-incidents#3476 (comment 1545305728)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Krasimir Angelov

Merge request reports